Refactoring duplicate switch logic to a single method.

cakephp · Jan 5, 2010 · da19e31 · da19e31
1 parent a3b0805
commit da19e31
Showing 1 changed file with 14 additions and 14 deletions.
diff --git a/cake/tests/lib/cake_test_menu.php b/cake/tests/lib/cake_test_menu.php
@@ -103,16 +103,8 @@ function analyzeCodeCoverage() {
  * @access public
  */
 	function testCaseList() {
-		switch (CAKE_TEST_OUTPUT) {
-			case CAKE_TEST_OUTPUT_HTML:
-				ob_start();
-				echo HtmlTestManager::getTestCaseList();
-				break;
-			case CAKE_TEST_OUTPUT_TEXT:
-			default:
-				echo TextTestManager::getTestCaseList();
-				break;
-		}
+		$class = CakeTestMenu::getTestManager();
+		echo call_user_func(array($class, 'getTestCaseList'));
 	}
 
 /**
@@ -122,14 +114,22 @@ function testCaseList() {
  * @access public
  */
 	function groupTestList() {
+		$class = CakeTestMenu::getTestManager();
+		echo call_user_func(array($class, 'getGroupTestList'));
+	}
+
+/**
+ * Gets the correct test manager for the chosen output.
+ *
+ * @return void
+ */
+	function getTestManager() {
 		switch (CAKE_TEST_OUTPUT) {
 			case CAKE_TEST_OUTPUT_HTML:
-				echo HtmlTestManager::getGroupTestList();
-				break;
+				return 'HtmlTestManager';
 			case CAKE_TEST_OUTPUT_TEXT:
 			default:
-				echo TextTestManager::getGroupTestList();
-				break;
+				return 'TextTestManager';
 		}
 	}