BreadcrumbsHelper::render() returns null with no crumbs

cakephp · Nov 26, 2016 · dc14d47 · dc14d47
1 parent f78ed4c
commit dc14d47
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/View/Helper/BreadcrumbsHelper.php b/src/View/Helper/BreadcrumbsHelper.php
@@ -235,10 +235,14 @@ public function getCrumbs()
      * - *innerAttrs* To provide attributes in case your separator is divided in two elements.
      * All other properties will be converted as HTML attributes and will replace the *attrs* key in the template.
      * If you use the default for this option (empty), it will not render a separator.
-     * @return string The breadcrumbs trail
+     * @return string|null The breadcrumbs trail
      */
     public function render(array $attributes = [], array $separator = [])
     {
+        if (empty($this->crumbs)) {
+            return null;
+        }
+
         $crumbs = $this->crumbs;
         $crumbsCount = count($crumbs);
         $templater = $this->templater();

diff --git a/tests/TestCase/View/Helper/BreadcrumbsHelperTest.php b/tests/TestCase/View/Helper/BreadcrumbsHelperTest.php
@@ -357,6 +357,8 @@ public function testInsertAfter()
      */
     public function testRender()
     {
+        $this->assertEmpty($this->breadcrumbs->render());
+
         $this->breadcrumbs
             ->add('Home', '/', ['class' => 'first', 'innerAttrs' => ['data-foo' => 'bar']])
             ->add('Some text', ['controller' => 'tests_apps', 'action' => 'some_method'])