Renamed EventManagerTrait to EventDispatcherTrait to better reflect t…

…hat it implements EventDispatcherInterface.
cakephp · Jul 21, 2015 · defeff0 · defeff0
1 parent 742f85d
commit defeff0
Show file tree

Hide file tree

Showing 15 changed files with 29 additions and 28 deletions.
diff --git a/config/bootstrap.php b/config/bootstrap.php
@@ -21,6 +21,7 @@
 if (PHP_VERSION_ID < 70000) {
     class_alias('Cake\Utility\Text', 'Cake\Utility\String');
 }
+class_alias('Cake\Event\EventDispatcherTrait', 'Cake\Event\EventManagerTrait');
 
 require CAKE . 'basics.php';
 

diff --git a/src/Controller/Component/AuthComponent.php b/src/Controller/Component/AuthComponent.php
@@ -19,7 +19,7 @@
 use Cake\Core\App;
 use Cake\Core\Exception\Exception;
 use Cake\Event\Event;
-use Cake\Event\EventManagerTrait;
+use Cake\Event\EventDispatcherTrait;
 use Cake\Network\Exception\ForbiddenException;
 use Cake\Network\Request;
 use Cake\Network\Response;
@@ -36,7 +36,7 @@
 class AuthComponent extends Component
 {
 
-    use EventManagerTrait;
+    use EventDispatcherTrait;
 
     /**
      * Constant for 'all'

diff --git a/src/Controller/ComponentRegistry.php b/src/Controller/ComponentRegistry.php
@@ -18,7 +18,7 @@
 use Cake\Core\App;
 use Cake\Core\ObjectRegistry;
 use Cake\Event\EventDispatcherInterface;
-use Cake\Event\EventManagerTrait;
+use Cake\Event\EventDispatcherTrait;
 
 /**
  * ComponentRegistry is a registry for loaded components
@@ -28,7 +28,7 @@
 class ComponentRegistry extends ObjectRegistry implements EventDispatcherInterface
 {
 
-    use EventManagerTrait;
+    use EventDispatcherTrait;
 
     /**
      * The controller that this collection was initialized with.

diff --git a/src/Controller/Controller.php b/src/Controller/Controller.php
@@ -19,7 +19,7 @@
 use Cake\Event\Event;
 use Cake\Event\EventDispatcherInterface;
 use Cake\Event\EventListenerInterface;
-use Cake\Event\EventManagerTrait;
+use Cake\Event\EventDispatcherTrait;
 use Cake\Log\LogTrait;
 use Cake\Network\Request;
 use Cake\Network\Response;
@@ -84,7 +84,7 @@
 class Controller implements EventListenerInterface, EventDispatcherInterface
 {
 
-    use EventManagerTrait;
+    use EventDispatcherTrait;
     use LogTrait;
     use MergeVariablesTrait;
     use ModelAwareTrait;

diff --git a/src/Core/ObjectRegistry.php b/src/Core/ObjectRegistry.php
@@ -28,7 +28,7 @@
  * the template method load().
  *
  * The ObjectRegistry is EventManager aware, but each extending class will need to use
- * \Cake\Event\EventManagerTrait to attach and detach on set and bind
+ * \Cake\Event\EventDispatcherTrait to attach and detach on set and bind
  *
  * @see \Cake\Controller\ComponentRegistry
  * @see \Cake\View\HelperRegistry

diff --git a/src/Event/EventDispatcherInterface.php b/src/Event/EventDispatcherInterface.php
@@ -22,7 +22,7 @@
  * Objects with this interface can trigger events, and have
  * an event manager retrieved from them.
  *
- * The Cake\Event\EventManagerTrait lets you easily implement
+ * The Cake\Event\EventDispatcherTrait lets you easily implement
  * this interface.
  */
 interface EventDispatcherInterface

diff --git a/src/Event/EventManagerTrait.php → src/Event/EventDispatcherTrait.php b/src/Event/EventManagerTrait.php → src/Event/EventDispatcherTrait.php
@@ -18,7 +18,7 @@
  * Provides the event manager interface features for usage in classes that require it.
  *
  */
-trait EventManagerTrait
+trait EventDispatcherTrait
 {
 
     /**

diff --git a/src/Event/README.md b/src/Event/README.md
@@ -13,12 +13,12 @@ of the action.
 
 ```php
 use Cake\Event\Event;
-use Cake\Event\EventManagerTrait;
+use Cake\Event\EventDispatcherTrait;
 
 class Orders
 {
 
-	use EventManagerTrait;
+	use EventDispatcherTrait;
 
 	public function placeOrder($order)
 	{

diff --git a/src/ORM/BehaviorRegistry.php b/src/ORM/BehaviorRegistry.php
@@ -18,7 +18,7 @@
 use Cake\Core\App;
 use Cake\Core\ObjectRegistry;
 use Cake\Event\EventDispatcherInterface;
-use Cake\Event\EventManagerTrait;
+use Cake\Event\EventDispatcherTrait;
 use Cake\ORM\Behavior;
 use Cake\ORM\Exception\MissingBehaviorException;
 use Cake\ORM\Table;
@@ -33,7 +33,7 @@
 class BehaviorRegistry extends ObjectRegistry implements EventDispatcherInterface
 {
 
-    use EventManagerTrait;
+    use EventDispatcherTrait;
 
     /**
      * The table using this registry.

diff --git a/src/ORM/Table.php b/src/ORM/Table.php
@@ -27,7 +27,7 @@
 use Cake\Event\EventDispatcherInterface;
 use Cake\Event\EventListenerInterface;
 use Cake\Event\EventManager;
-use Cake\Event\EventManagerTrait;
+use Cake\Event\EventDispatcherTrait;
 use Cake\ORM\AssociationCollection;
 use Cake\ORM\Association\BelongsTo;
 use Cake\ORM\Association\BelongsToMany;
@@ -122,7 +122,7 @@
 class Table implements RepositoryInterface, EventListenerInterface, EventDispatcherInterface
 {
 
-    use EventManagerTrait;
+    use EventDispatcherTrait;
     use RulesAwareTrait;
     use ValidatorAwareTrait;
 

diff --git a/src/Routing/Dispatcher.php b/src/Routing/Dispatcher.php
@@ -16,7 +16,7 @@
 
 use Cake\Controller\Controller;
 use Cake\Event\EventListenerInterface;
-use Cake\Event\EventManagerTrait;
+use Cake\Event\EventDispatcherTrait;
 use Cake\Network\Request;
 use Cake\Network\Response;
 use Cake\Routing\Exception\MissingControllerException;
@@ -31,7 +31,7 @@
 class Dispatcher
 {
 
-    use EventManagerTrait;
+    use EventDispatcherTrait;
 
     /**
      * Connected filter objects

diff --git a/src/View/Cell.php b/src/View/Cell.php
@@ -16,7 +16,7 @@
 
 use Cake\Datasource\ModelAwareTrait;
 use Cake\Event\EventManager;
-use Cake\Event\EventManagerTrait;
+use Cake\Event\EventDispatcherTrait;
 use Cake\Network\Request;
 use Cake\Network\Response;
 use Cake\Utility\Inflector;
@@ -31,7 +31,7 @@
 abstract class Cell
 {
 
-    use EventManagerTrait;
+    use EventDispatcherTrait;
     use ModelAwareTrait;
     use ViewVarsTrait;
 

diff --git a/src/View/HelperRegistry.php b/src/View/HelperRegistry.php
@@ -17,7 +17,7 @@
 use Cake\Core\App;
 use Cake\Core\ObjectRegistry;
 use Cake\Event\EventDispatcherInterface;
-use Cake\Event\EventManagerTrait;
+use Cake\Event\EventDispatcherTrait;
 use Cake\View\View;
 
 /**
@@ -27,7 +27,7 @@
 class HelperRegistry extends ObjectRegistry implements EventDispatcherInterface
 {
 
-    use EventManagerTrait;
+    use EventDispatcherTrait;
 
     /**
      * View object to use when making helpers.

diff --git a/src/View/View.php b/src/View/View.php
@@ -19,7 +19,7 @@
 use Cake\Core\Plugin;
 use Cake\Event\EventDispatcherInterface;
 use Cake\Event\EventManager;
-use Cake\Event\EventManagerTrait;
+use Cake\Event\EventDispatcherTrait;
 use Cake\Log\LogTrait;
 use Cake\Network\Request;
 use Cake\Network\Response;
@@ -62,7 +62,7 @@ class View implements EventDispatcherInterface
 {
 
     use CellTrait;
-    use EventManagerTrait;
+    use EventDispatcherTrait;
     use LogTrait;
     use RequestActionTrait;
     use ViewVarsTrait;

diff --git a/.../TestCase/Event/EventManagerTraitTest.php → ...stCase/Event/EventDispatcherTraitTest.php b/.../TestCase/Event/EventManagerTraitTest.php → ...stCase/Event/EventDispatcherTraitTest.php
@@ -15,14 +15,14 @@
 namespace Cake\Test\TestCase\Event;
 
 use Cake\Event\EventManager;
-use Cake\Event\EventManagerTrait;
+use Cake\Event\EventDispatcherTrait;
 use Cake\TestSuite\TestCase;
 
 /**
- * EventManagerTrait test case
+ * EventDispatcherTrait test case
  *
  */
-class EventManagerTraitTest extends TestCase
+class EventDispatcherTraitTest extends TestCase
 {
 
     /**
@@ -34,7 +34,7 @@ public function setUp()
     {
         parent::setUp();
 
-        $this->subject = $this->getObjectForTrait('Cake\Event\EventManagerTrait');
+        $this->subject = $this->getObjectForTrait('Cake\Event\EventDispatcherTrait');
     }
 
     /**
@@ -50,7 +50,7 @@ public function testIsInitiallyEmpty()
     /**
      * testSettingEventManager
      *
-     * @covers \Cake\Event\EventManagerTrait::eventManager
+     * @covers \Cake\Event\EventDispatcherTrait::eventManager
      * @return void
      */
     public function testSettingEventManager()