Switch from LEFT to INNER joins.

INNER joins are often more efficient as they can result in fewer rows being examined before a result set is generated. Fixes #3968
cakephp · Aug 7, 2013 · e36c537 · e36c537
1 parent dc15c78
commit e36c537
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/Cake/Model/AclNode.php b/lib/Cake/Model/AclNode.php
@@ -85,7 +85,7 @@ public function node($ref = null) {
 				'joins' => array(array(
 					'table' => $table,
 					'alias' => "{$type}0",
-					'type' => 'LEFT',
+					'type' => 'INNER',
 					'conditions' => array("{$type}0.alias" => $start)
 				)),
 				'order' => $db->name("{$type}.lft") . ' DESC'
@@ -97,7 +97,7 @@ public function node($ref = null) {
 				$queryData['joins'][] = array(
 					'table' => $table,
 					'alias' => "{$type}{$i}",
-					'type' => 'LEFT',
+					'type' => 'INNER',
 					'conditions' => array(
 						$db->name("{$type}{$i}.lft") . ' > ' . $db->name("{$type}{$j}.lft"),
 						$db->name("{$type}{$i}.rght") . ' < ' . $db->name("{$type}{$j}.rght"),