Skip to content

Commit

Permalink
More DS corrections.
Browse files Browse the repository at this point in the history
  • Loading branch information
euromark committed Dec 20, 2014
1 parent 243ea3c commit e413acc
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion tests/TestCase/Console/ShellTest.php
Expand Up @@ -481,7 +481,7 @@ public function testCreateFileOverwrite() {
* @return void
*/
public function testCreateFileNoPermissions() {
$this->skipIf(DIRECTORY_SEPARATOR === '\\', 'Cant perform operations using permissions on windows.');
$this->skipIf(DS === '\\', 'Cant perform operations using permissions on windows.');

$path = TMP . 'shell_test';
$file = $path . DS . 'no_perms';
Expand Down
2 changes: 1 addition & 1 deletion tests/TestCase/Filesystem/FileTest.php
Expand Up @@ -128,7 +128,7 @@ function_exists('mime_content_type') &&
* @return void
*/
public function testPermission() {
$this->skipIf(DIRECTORY_SEPARATOR === '\\', 'File permissions tests not supported on Windows.');
$this->skipIf(DS === '\\', 'File permissions tests not supported on Windows.');

$dir = TMP . 'tests' . DS . 'permissions' . DS;
$old = umask();
Expand Down
4 changes: 2 additions & 2 deletions tests/TestCase/Filesystem/FolderTest.php
Expand Up @@ -172,7 +172,7 @@ public function testCreateRelative() {
* @return void
*/
public function testRecursiveCreateFailure() {
$this->skipIf(DIRECTORY_SEPARATOR === '\\', 'Cant perform operations using permissions on windows.');
$this->skipIf(DS === '\\', 'Cant perform operations using permissions on windows.');

$path = TMP . 'tests/one';
mkdir($path, 0777, true);
Expand Down Expand Up @@ -267,7 +267,7 @@ public function testOperations() {
* @return void
*/
public function testChmod() {
$this->skipIf(DIRECTORY_SEPARATOR === '\\', 'Folder permissions tests not supported on Windows.');
$this->skipIf(DS === '\\', 'Folder permissions tests not supported on Windows.');

$path = TMP . 'tests/';
$Folder = new Folder($path);
Expand Down
6 changes: 3 additions & 3 deletions tests/TestCase/Shell/PluginAssetsShellTest.php
Expand Up @@ -36,7 +36,7 @@ public function setUp() {
parent::setUp();

$this->skipIf(
DIRECTORY_SEPARATOR === '\\',
DS === '\\',
'Skip PluginAssetsShell tests on windows to prevent side effects for UrlHelper tests on AppVeyor.'
);

Expand Down Expand Up @@ -74,7 +74,7 @@ public function testSymlink() {
$path = WWW_ROOT . 'test_plugin';
$link = new \SplFileInfo($path);
$this->assertTrue(file_exists($path . DS . 'root.js'));
if (DIRECTORY_SEPARATOR === '\\') {
if (DS === '\\') {
$this->assertTrue($link->isDir());
$folder = new Folder($path);
$folder->delete();
Expand Down Expand Up @@ -107,7 +107,7 @@ public function testSymlinkWhenVendorDirectoryExits() {
$this->shell->symlink();
$path = WWW_ROOT . 'company' . DS . 'test_plugin_three';
$link = new \SplFileInfo($path);
if (DIRECTORY_SEPARATOR === '\\') {
if (DS === '\\') {
$this->assertTrue($link->isDir());
} else {
$this->assertTrue($link->isLink());
Expand Down

0 comments on commit e413acc

Please sign in to comment.