use try/finally to avoid side effect

cakephp · Oct 9, 2017 · e737cf9 · e737cf9
1 parent ddb31e8
commit e737cf9
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/TestSuite/TestCase.php b/src/TestSuite/TestCase.php
@@ -95,10 +95,13 @@ public function skipIf($shouldSkip, $message = '')
      */
     public function deprecated($callable)
     {
-        $errorLevel = error_reporting();
-        error_reporting(E_ALL ^ E_USER_DEPRECATED);
-        $callable();
-        error_reporting($errorLevel);
+        try {
+            $errorLevel = error_reporting();
+            error_reporting(E_ALL ^ E_USER_DEPRECATED);
+            $callable();
+        } finally {
+            error_reporting($errorLevel);
+        }
     }
 
     /**