Making ControllerTestCase abstract, that way PHP won't complain about…

… empty test cases, closes #1868
cakephp · Jul 31, 2011 · eaa0163 · eaa0163
1 parent b15c77e
commit eaa0163
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/Cake/Test/Case/TestSuite/ControllerTestCaseTest.php b/lib/Cake/Test/Case/TestSuite/ControllerTestCaseTest.php
@@ -98,6 +98,10 @@ class ControllerTestCaseTestController extends AppController {
 
 }
 
+/**
+ * Used to get a testable concrete class of the test subject
+ */
+class TestingControllerTestCase extends ControllerTestCase {}
 
 /**
  * ControllerTestCaseTest
@@ -128,7 +132,7 @@ public function setUp() {
 			'View' => array(CAKE . 'Test' . DS . 'test_app' . DS . 'View' . DS)
 		));
 		CakePlugin::loadAll();
-		$this->Case = new ControllerTestCase();
+		$this->Case = new TestingControllerTestCase();
 		Router::reload();
 	}
 

diff --git a/lib/Cake/TestSuite/ControllerTestCase.php b/lib/Cake/TestSuite/ControllerTestCase.php
@@ -98,7 +98,7 @@ public function afterRender($viewFile) {
  *
  * @package       Cake.TestSuite
  */
-class ControllerTestCase extends CakeTestCase {
+abstract class ControllerTestCase extends CakeTestCase {
 
 /**
  * The controller to test in testAction