Skip to content

Commit

Permalink
Remove todo's whihc have been removed in e02eab0
Browse files Browse the repository at this point in the history
and accidentally been re-added in 3e3af1f
  • Loading branch information
ceeram committed Dec 10, 2012
1 parent 505cf3d commit ec3e7af
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions lib/Cake/Network/Http/HttpSocketResponse.php
Expand Up @@ -226,27 +226,20 @@ protected function _decodeChunkedBody($body) {

$chunkSize = 0;
$hexLength = 0;
$chunkExtensionName = '';
$chunkExtensionValue = '';
if (isset($match[0])) {
$chunkSize = $match[0];
}
if (isset($match[1])) {
$hexLength = $match[1];
}
if (isset($match[2])) {
$chunkExtensionName = $match[2];
}
if (isset($match[3])) {
$chunkExtensionValue = $match[3];
}

$body = substr($body, strlen($chunkSize));
$chunkLength = hexdec($hexLength);
$chunk = substr($body, 0, $chunkLength);
if (!empty($chunkExtensionName)) {
// @todo See if there are popular chunk extensions we should implement
}
$decodedBody .= $chunk;
if ($chunkLength !== 0) {
$body = substr($body, $chunkLength + strlen("\r\n"));
Expand Down Expand Up @@ -298,7 +291,6 @@ protected function _parseHeader($header) {
*
* @param array $header Header array containing one ore more 'Set-Cookie' headers.
* @return mixed Either false on no cookies, or an array of cookies received.
* @todo Make this 100% RFC 2965 confirm
*/
public function parseCookies($header) {
$cookieHeader = $this->getHeader('Set-Cookie', $header);
Expand Down Expand Up @@ -341,7 +333,6 @@ public function parseCookies($header) {
* @param string $token Token to unescape
* @param array $chars
* @return string Unescaped token
* @todo Test $chars parameter
*/
protected function _unescapeToken($token, $chars = null) {
$regex = '/"([' . implode('', $this->_tokenEscapeChars(true, $chars)) . '])"/';
Expand All @@ -355,7 +346,6 @@ protected function _unescapeToken($token, $chars = null) {
* @param boolean $hex true to get them as HEX values, false otherwise
* @param array $chars
* @return array Escape chars
* @todo Test $chars parameter
*/
protected function _tokenEscapeChars($hex = true, $chars = null) {
if (!empty($chars)) {
Expand Down

0 comments on commit ec3e7af

Please sign in to comment.