Skip to content

Commit

Permalink
Optimization for Hash method
Browse files Browse the repository at this point in the history
  • Loading branch information
jrbasso committed Jun 24, 2012
1 parent 3e28326 commit ecdf0e6
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions lib/Cake/Utility/Hash.php
Expand Up @@ -47,7 +47,7 @@ public static function get(array $data, $path) {
} else {
$parts = $path;
}
while (($key = array_shift($parts)) !== null) {
foreach ($parts as $key) {
if (is_array($data) && isset($data[$key])) {
$data =& $data[$key];
} else {
Expand Down Expand Up @@ -106,8 +106,7 @@ public static function extract(array $data, $path) {

$context = array($_key => array($data));

do {
$token = array_shift($tokens);
foreach ($tokens as $token) {
$next = array();

$conditions = false;
Expand Down Expand Up @@ -137,7 +136,7 @@ public static function extract(array $data, $path) {
}
$context = array($_key => $next);

} while (!empty($tokens));
}
return $context[$_key];
}

Expand Down Expand Up @@ -176,12 +175,7 @@ protected static function _matches(array $data, $selector) {
PREG_SET_ORDER
);

$ok = true;
while ($ok) {
if (empty($conditions)) {
break;
}
$cond = array_shift($conditions);
foreach ($conditions as $cond) {
$attr = $cond['attr'];
$op = isset($cond['op']) ? $cond['op'] : null;
$val = isset($cond['val']) ? $cond['val'] : null;
Expand Down

1 comment on commit ecdf0e6

@flotwig
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply beautiful. :)

Please sign in to comment.