Update Query::$primary and Query::primary() names.

To Query::eagerLoaded and Query::eagerLoaded(), respectively. To reflect
the real purpose of the variable/function.

Author: bar

src/Datasource/QueryTrait.php

@@ -185,7 +185,7 @@ public function all() {
 		}
 
 		$table = $this->repository();
-		$event = new Event('Model.beforeFind', $table, [$this, $this->_options, $this->primary()]);
+		$event = new Event('Model.beforeFind', $table, [$this, $this->_options, $this->eagerLoaded()]);
 		$table->getEventManager()->dispatch($event);
 
 		if (isset($this->_results)) {

src/ORM/Association.php

@@ -418,7 +418,7 @@ public function attachTo(Query $query, array $options = []) {
 		}
 
 		$options['conditions'] = $query->newExpr()->add($options['conditions']);
-		$dummy = $target->query()->primary(false);
+		$dummy = $target->query()->eagerLoaded(false);
 
 		if (!empty($options['queryBuilder'])) {
 			$dummy = $options['queryBuilder']($dummy);

src/ORM/Association/ExternalAssociationTrait.php

@@ -228,7 +228,7 @@ protected function _buildQuery($options) {
 		$fetchQuery = $this
 			->find('all')
 			->where($options['conditions'])
-			->primary(false)
+			->eagerLoaded(false)
 			->hydrate($options['query']->hydrate());
 		$fetchQuery = $this->_addFilteringCondition($fetchQuery, $key, $filter);
 

src/ORM/Query.php

@@ -100,7 +100,7 @@ class Query extends DatabaseQuery {
  *
  * @var boolean
  */
-	protected $_primary = true;
+	protected $_eagerLoaded = true;
 
 /**
  * Constuctor
@@ -654,17 +654,17 @@ protected function _dirty() {
 	}
 
 /**
- * Sets the query instance to be the primary query. If no argument is passed,
- * the current configured query `_primary` value is returned.
+ * Sets the query instance to be the eager loaded query. If no argument is
+ * passed, the current configured query `_eagerLoaded` value is returned.
  *
  * @param boolean $value
  * @return \Cake\ORM\Query
  */
-	public function primary($value = null) {
+	public function eagerLoaded($value = null) {
 		if ($value === null) {
-			return $this->_primary;
+			return $this->_eagerLoaded;
 		}
-		$this->_primary = $value;
+		$this->_eagerLoaded = $value;
 		return $this;
 	}
 

src/ORM/Table.php

@@ -73,7 +73,7 @@
  * Table objects provide a few callbacks/events you can hook into to augment/replace
  * find operations. Each event uses the standard event subsystem in CakePHP
  *
- * - `beforeFind($event, $query, $options, $primary)` - Fired before each find operation.
+ * - `beforeFind($event, $query, $options, $eagerLoaded)` - Fired before each find operation.
  *   By stopping the event and supplying a return value you can bypass the find operation
  *   entirely. Any changes done to the $query instance will be retained for the rest of the find.
  * - `beforeValidate($event, $entity, $options, $validator)` - Fired before an entity is validated.