Adding a fix for #5463

cakephp · Dec 23, 2014 · f111af3 · f111af3
1 parent 16c36b1
commit f111af3
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/src/ORM/ResultSet.php b/src/ORM/ResultSet.php
@@ -283,11 +283,12 @@ protected function _calculateAssociationMap() {
 		$map = $this->_query->eagerLoader()->associationsMap($this->_defaultTable);
 		$this->_matchingMap = (new Collection($map))
 			->match(['matching' => true])
-			->compile();
+			->toArray();
 
 		$this->_containMap = (new Collection(array_reverse($map)))
 			->match(['matching' => false])
-			->compile();
+			->indexBy('nestKey')
+			->toArray();
 	}
 
 /**
@@ -331,7 +332,10 @@ protected function _groupResult($row) {
 				}
 				list($table, $field) = explode('__', $key);
 				$results['_matchingData'][$table][$field] = $value;
-				unset($row[$key]);
+
+				if (!isset($this->_containMap[$table])) {
+					unset($row[$key]);
+				}
 			}
 			if (empty($results['_matchingData'][$matching['alias']])) {
 				continue;
@@ -343,6 +347,7 @@ protected function _groupResult($row) {
 			);
 
 			if ($this->_hydrate) {
+				$options['source'] = $matching['alias'];
 				$entity = new $matching['entityClass']($results['_matchingData'][$matching['alias']], $options);
 				$entity->clean();
 				$results['_matchingData'][$matching['alias']] = $entity;

diff --git a/tests/TestCase/ORM/QueryRegressionTest.php b/tests/TestCase/ORM/QueryRegressionTest.php
@@ -576,4 +576,23 @@ public function testFirstOnResultSet() {
 		$this->assertCount(3, $results->toArray());
 	}
 
+/**
+ * Checks that matching and contain can be called for the same belongsTo association
+ *
+ * @see https://github.com/cakephp/cakephp/issues/5463
+ * @return void
+ */
+	public function testFindMatchingAndContain() {
+		$table = TableRegistry::get('Articles');
+		$table->belongsTo('Authors');
+		$article = $table->find()
+			->contain('Authors')
+			->matching('Authors', function ($q) {
+				return $q->where(['Authors.id' => 1]);
+			})
+			->first();
+		$this->assertNotNull($article->author);
+		$this->assertEquals($article->author, $article->_matchingData['Authors']);
+	}
+
 }