Skip to content

Commit f19615a

Browse files
author
Gilles Wittenberg
committed
Allow setting different type on scriptBlock
1 parent 28a3b73 commit f19615a

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

lib/Cake/Test/Case/View/Helper/HtmlHelperTest.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1067,6 +1067,16 @@ public function testScriptBlock() {
10671067
);
10681068
$this->assertTags($result, $expected);
10691069

1070+
$result = $this->Html->scriptBlock('window.foo = 2;', array('type' => 'text/x-handlebars-template'));
1071+
$expected = array(
1072+
'script' => array('type' => 'text/x-handlebars-template'),
1073+
$this->cDataStart,
1074+
'window.foo = 2;',
1075+
$this->cDataEnd,
1076+
'/script',
1077+
);
1078+
$this->assertTags($result, $expected);
1079+
10701080
$result = $this->Html->scriptBlock('window.foo = 2;', array('safe' => false));
10711081
$expected = array(
10721082
'script' => array('type' => 'text/javascript'),

lib/Cake/View/Helper/HtmlHelper.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ class HtmlHelper extends AppHelper {
9898
'ol' => '<ol%s>%s</ol>',
9999
'li' => '<li%s>%s</li>',
100100
'error' => '<div%s>%s</div>',
101-
'javascriptblock' => '<script type="text/javascript"%s>%s</script>',
101+
'javascriptblock' => '<script%s>%s</script>',
102102
'javascriptstart' => '<script type="text/javascript">',
103103
'javascriptlink' => '<script type="text/javascript" src="%s"%s></script>',
104104
'javascriptend' => '</script>'
@@ -560,7 +560,7 @@ public function script($url, $options = array()) {
560560
* @link http://book.cakephp.org/2.0/en/core-libraries/helpers/html.html#HtmlHelper::scriptBlock
561561
*/
562562
public function scriptBlock($script, $options = array()) {
563-
$options += array('safe' => true, 'inline' => true);
563+
$options += array('type' => 'text/javascript', 'safe' => true, 'inline' => true);
564564
if ($options['safe']) {
565565
$script = "\n" . '//<![CDATA[' . "\n" . $script . "\n" . '//]]>' . "\n";
566566
}

0 commit comments

Comments
 (0)