The SessionHandlerInterface requires some methods to return boolean

We were returning mixed types on DatabaseSession, which made hhvm super unhappy. This also future-proofs the class for PHP 7
cakephp · Apr 1, 2015 · f1d1b99 · f1d1b99
1 parent 236b513
commit f1d1b99
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/src/Network/Session/DatabaseSession.php b/src/Network/Session/DatabaseSession.php
@@ -121,10 +121,7 @@ public function write($id, $data)
         $record = compact('data', 'expires');
         $record[$this->_table->primaryKey()] = $id;
         $result = $this->_table->save(new Entity($record));
-        if ($result) {
-            return $result->toArray();
-        }
-        return false;
+        return (bool)$result;
     }
 
     /**
@@ -135,7 +132,7 @@ public function write($id, $data)
      */
     public function destroy($id)
     {
-        return $this->_table->delete(new Entity(
+        return (bool)$this->_table->delete(new Entity(
             [$this->_table->primaryKey() => $id],
             ['markNew' => false]
         ));
@@ -149,6 +146,7 @@ public function destroy($id)
      */
     public function gc($maxlifetime)
     {
-        return $this->_table->deleteAll(['expires <' => time() - $maxlifetime]);
+        $this->_table->deleteAll(['expires <' => time() - $maxlifetime]);
+        return true;
     }
 }
diff --git a/tests/TestCase/Network/Session/DatabaseSessionTest.php b/tests/TestCase/Network/Session/DatabaseSessionTest.php
@@ -97,14 +97,9 @@ public function testOpen()
     public function testWrite()
     {
         $result = $this->storage->write('foo', 'Some value');
-        $expected = [
-            'id' => 'foo',
-            'data' => 'Some value',
-        ];
-        $expires = $result['expires'];
-        unset($result['expires']);
-        $this->assertEquals($expected, $result);
+        $this->assertTrue($result);
 
+        $expires = TableRegistry::get('Sessions')->get('foo')->expires;
         $expected = time() + ini_get('session.gc_maxlifetime');
         $this->assertWithinRange($expected, $expires, 1);
     }