Updating EmailComponent to use new methods on the ComponentCollection to ensure it always has a controller reference.

Removing triggerDisabled key as its no longer needed or wanted.

Author: markstory

cake/libs/controller/components/email.php

@@ -298,13 +298,23 @@ class EmailComponent extends Component {
  */
 	protected $_smtpConnection = null;
 
+/**
+ * Constructor
+ *
+ * @param ComponentCollection $collection A ComponentCollection this component can use to lazy load its components
+ * @param array $settings Array of configuration settings.
+ */
+	public function __construct(ComponentCollection $collection, $settings = array()) {
+		$this->Controller = $collection->getController();
+		parent::__construct($collection, $settings);
+	}
+
 /**
  * Initialize component
  *
  * @param object $controller Instantiating controller
  */
 	public function initialize(&$controller) {
-		$this->Controller = $controller;
 		if (Configure::read('App.encoding') !== null) {
 			$this->charset = Configure::read('App.encoding');
 		}

cake/libs/controller/controller.php

@@ -533,7 +533,7 @@ public function getResponse() {
  * @return void
  */
 	public function startupProcess() {
-		$this->Components->trigger('initialize', array(&$this), array('triggerDisabled' => true));
+		$this->Components->trigger('initialize', array(&$this));
 		$this->beforeFilter();
 		$this->Components->trigger('startup', array(&$this));
 	}

cake/tests/cases/libs/controller/controller.test.php

@@ -1478,7 +1478,7 @@ function testStartupProcess() {
 
 		$Controller->expects($this->once())->method('beforeFilter');
 		$Controller->Components->expects($this->at(0))->method('trigger')
-			->with('initialize', array(&$Controller), array('triggerDisabled' => true));
+			->with('initialize', array(&$Controller));
 
 		$Controller->Components->expects($this->at(1))->method('trigger')
 			->with('startup', array(&$Controller));