Make function first in stack trace.

cakephp · Dec 1, 2014 · f40cba9 · f40cba9
1 parent 43b1469
commit f40cba9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/Template/Element/exception_stack_trace_nav.ctp b/src/Template/Element/exception_stack_trace_nav.ctp
@@ -19,14 +19,14 @@ use Cake\Error\Debugger;
 	<li class="stack-frame">
 	<?php if (isset($stack['file']) && isset($stack['line'])): ?>
 		<a href="#" data-target="stack-frame-<?= $i ?>">
-			<span class="stack-file"><?= h(Debugger::trimPath($stack['file'])) ?></span>
 			<?php if (!isset($stack['class'])): ?>
 				<span class="stack-function"><?= h($stack['function']) ?></span>
 			<?php else: ?>
 				<span class="stack-function"><?= h($stack['class']) ?>::<?= h($stack['function']) ?></span>
 			<?php endif; ?>
-			, line
-			<span class="stack-line"><?= $stack['line'] ?></span>
+			<span class="stack-file">
+				<?= h(Debugger::trimPath($stack['file'])) ?>, line <?= $stack['line'] ?>
+			</span>
 		</a>
 	<?php else: ?>
 		<a href="#">[internal function]</a>

diff --git a/src/Template/Layout/dev_error.ctp b/src/Template/Layout/dev_error.ctp
@@ -188,6 +188,7 @@ header {
 	padding: 10px;
 }
 .stack-frame a {
+	display: block;
 	color: #626262;
 }
 .stack-frame.active {
@@ -203,6 +204,12 @@ header {
 .stack-file {
 	font-family: consolas, monospace;
 }
+.stack-function {
+	font-weight: bold;
+}
+.stack-file {
+	font-size: 0.9em;
+}
 
 .stack-details {
 	background: #ececec;