Skip to content

Commit

Permalink
Added missing option arrays to abstract function definitions in JsBas…
Browse files Browse the repository at this point in the history
…eEngineHelper. Fixed test cases accordingly. Fixes #704 .
  • Loading branch information
Thomas Ploch authored and markstory committed Jul 14, 2010
1 parent eda79ae commit fb9faf1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions cake/libs/view/helpers/js.php
Expand Up @@ -912,7 +912,7 @@ abstract public function drop($options = array());
* @param array $options Array of options for the sortable. See above.
* @return string Completed sortable script.
*/
abstract public function sortable();
abstract public function sortable($options = array());

/**
* Create a slider UI widget. Comprised of a track and knob.
Expand All @@ -934,7 +934,7 @@ abstract public function sortable();
*
* @return string Completed slider script
*/
abstract public function slider();
abstract public function slider($options = array());
/**
* Serialize the form attached to $selector.
* Pass `true` for $isForm if the current selection is a form element.
Expand All @@ -949,7 +949,7 @@ abstract public function slider();
* @param array $options options for serialization generation.
* @return string completed form serialization script
*/
abstract public function serializeForm();
abstract public function serializeForm($options = array());

/**
* Parse an options assoc array into an Javascript object literal.
Expand Down
8 changes: 4 additions & 4 deletions cake/tests/cases/libs/view/helpers/js.test.php
Expand Up @@ -52,13 +52,13 @@ function get($selector) {}
function event($type, $callback, $options = array()) {}
function domReady($functionBody) {}
function each($callback) {}
function effect($name, $options) {}
function effect($name, $options = array()) {}
function request($url, $options = array()) {}
function drag($options = array()) {}
function drop($options = array()) {}
function sortable() {}
function slider() {}
function serializeForm() {}
function sortable($options = array()) {}
function slider($options = array()) {}
function serializeForm($options = array()) {}
}

/**
Expand Down

0 comments on commit fb9faf1

Please sign in to comment.