Fixing lastInserId() use

cakephp · Mar 19, 2016 · fef4769 · fef4769
1 parent 135aa72
commit fef4769
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/tests/TestCase/Database/QueryTest.php b/tests/TestCase/Database/QueryTest.php
@@ -3604,16 +3604,18 @@ public function testSelectTypeConversion()
     public function testSymetricJsonType()
     {
         $query = new Query($this->connection);
-        $id = $query
+        $insert = $query
             ->insert(['comment', 'article_id', 'user_id'], ['comment' => 'json'])
             ->into('comments')
             ->values([
                 'comment' => ['a' => 'b', 'c' => true],
                 'article_id' => 1,
                 'user_id' => 1
             ])
-            ->execute()
-            ->lastInsertId('id');
+            ->execute();
+
+        $id = $insert->lastInsertId('comments', 'id');
+        $insert->closeCursor();
 
         $query = new Query($this->connection);
         $query
@@ -3622,8 +3624,10 @@ public function testSymetricJsonType()
             ->where(['id' => $id])
             ->selectTypeMap()->types(['comment' => 'json']);
 
-        $result = $query->execute()->fetchAll('assoc')[0]['comment'];
-        $this->assertSame(['a' => 'b', 'c' => true], $result);
+        $result = $query->execute();
+        $comment = $result->fetchAll('assoc')[0]['comment'];
+        $result->closeCursor();
+        $this->assertSame(['a' => 'b', 'c' => true], $comment);
     }
 
     /**