New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fullWidth not work in RaisedButton when upgrade to 0.15.0 #4226
Comments
Since this prop is being used, lets get the fix in to 0.15.1, and we can deprecate in favour of style in 0.16.0. |
can confirm. All it needs is a |
@mbrookes @oliviertassinari ...
return {
root: {
display: 'inline-block',
transition: transitions.easeOut(),
minWidth: fullWidth ? '100%' : button.minWidth,
},
button: {
position: 'relative',
height: buttonHeight,
lineHeight: `${buttonHeight}px`,
width: '100%',
padding: 0,
borderRadius: borderRadius,
transition: transitions.easeOut(),
backgroundColor: backgroundColor,
// That's the default value for a button but not a link
textAlign: 'center',
}
... But when I check $ pwd
/Users/scarlex/Projects/testlibs/node_modules/material-ui
$ tail package.json
"react-tap-event-plugin": "^1.0.0"
},
"readme": "ERROR: No README data found!",
"repository": {
"type": "git",
"url": "git+https://github.com/callemall/material-ui.git"
},
"scripts": {},
"version": "0.15.1"
}
$ cat RaisedButton/RaisedButton.js
...
return {
root: {
display: 'inline-block',
transition: _transitions2.default.easeOut()
},
button: {
position: 'relative',
minWidth: fullWidth ? '100%' : button.minWidth,
height: buttonHeight,
lineHeight: buttonHeight + 'px',
width: '100%',
padding: 0,
borderRadius: borderRadius,
transition: _transitions2.default.easeOut(),
backgroundColor: backgroundColor,
// That's the default value for a button but not a link
textAlign: 'center'
},
... I have no idea why |
@scarletsky some commits are missing from the |
@oliviertassinari 😃 Oh, I see, thanks for your reply ! |
Problem description
fullWidth
not work in RaisedButton when upgrade to 0.15.0.In 0.15.0-beta.2, it works.
Steps to reproduce
Just set
fullWidth
totrue
in RaisedButton.Versions
The text was updated successfully, but these errors were encountered: