Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.15.2 release #4572

Closed
wants to merge 47 commits into from

Conversation

alitaheri
Copy link
Member

@alitaheri alitaheri commented Jun 26, 2016

@callemall/material-ui Take a look please. I hope this release will fix all the shortcomings of the last one.

mbrookes and others added 24 commits June 26, 2016 14:01
alphabetize styles

Update CalendarYear.js

add prepareStyles
Currently it is only possible to style the icon if the entire MenuItem is in desktop mode. Be consistent with the right icon and allow styling.
Affects the following components: Checkbox, DatePicker, EnhancedTextarea, IconButton, ListItem, MenuItem, RadioButton, SelectField, Stepper, Table, TextField, Toggle
some values of a style can be nulls and doesnt need a replacement. we need to skeep them.
Plese not that in the cases like 'direction' (#L44) we want replacment for null anyway.
So only when we invoke function we check for null.

Fix for this issue:
mui#4364
@alitaheri alitaheri added this to the 0.15.2 milestone Jun 26, 2016
@muibot muibot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: Needs Review labels Jul 1, 2016
hhaidar and others added 3 commits July 6, 2016 01:09
Continuation of mui#4531.

There are several cases where `onMouseLeave` (which normally unsets
the `hovered` state won't be called). One of those is if you disable a
button within the `onTouchTap` method.

This check ensures that a button will never be disabled but have an
internal hovered state.

Closes mui#4531.
@alitaheri alitaheri removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Jul 5, 2016
@alitaheri
Copy link
Member Author

@callemall/material-ui I think this is ready. please have a look 😁

@muibot muibot added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Jul 5, 2016
@alitaheri
Copy link
Member Author

Rebase gone wrong 😱

@alitaheri alitaheri removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Jul 5, 2016
@abilashs90
Copy link

When is it expected to be released? My console gives me a heart attack every single time I look at it 😁

@namwkim
Copy link

namwkim commented Jul 7, 2016

Just started using it. Another heart attack here.

@DarrylD
Copy link

DarrylD commented Jul 8, 2016

These mini-heart attacks from this error are really shaving days off my life 💀. For the future, is there a way to suppress such errors?

@MomenYasser
Copy link

Guys we actually still waiting the new release ... any updates ??

@rustanacexd
Copy link

yeah me too. it's not yet fixed on the latest version.

@oliviertassinari
Copy link
Member

yeah me too. it's not yet fixed on the latest version.

Could you give more details?

@qiuchengw
Copy link

qiuchengw commented Jul 20, 2016

@oliviertassinari

Take SelectableList for example (also visit material-ui Selectable List )

  const SelectableList = MakeSelectable(List); 
  <SelectableList ...>
     <ListItem ...>
     ...
  </SelectableList>

Warning is:

warning.js?8a56:44 Warning: Unknown prop onTouchTap on <span> tag. Remove this prop from the element

Versions:

react : v15.2.1
material-ui: v0.15.2

@oliviertassinari
Copy link
Member

@qiuchengw You need to use react-tap-event-plugin. Please open an issue next time. That would help more users.

@mui mui locked and limited conversation to collaborators Jul 22, 2016
@zannager zannager added the docs Improvements or additions to the documentation label Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.