docs(engine-rest): return stacktrace as text/plain #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifies the schema for plain text responses as type 'string'. This is required for generated API clients to work properly, as they usually default to application/json.
Fixed:
* history/job-log/{id}/stacktrace
* /job/{id}/stacktrace
|
Hi @nicoruti, thank you for your contribution. 🚀 |
mboskamp
requested changes
Jul 19, 2023
There was a problem hiding this comment.
Hi @nicoruti, sorry for the long wait.
It looks like your change breaks the template in some ways. Could you check this again? Please make sure that mvn clean install still works in the engine-rest-openapi project.
It is also not clear to me why this change should be necessary as both endpoints already declare mediaType= "text/plain". Could you elaborate on this as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifies the schema for plain text responses as type 'string'. This is required for generated API clients to work properly, as they usually default to application/json.
Fixed: