chore(engine): add operation log for sync delete process instance #4028
+198
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mboskamp
force-pushed
the
3900-sync-message-correlation-op-log
branch
from
066b4c0
to
b4382df
Compare
mboskamp
force-pushed
the
3900-sync-message-correlation-op-log
branch
from
b4382df
to
5939769
Compare
Base automatically changed from
3900-sync-message-correlation-op-log
to
master
January 19, 2024 14:30
mboskamp
force-pushed
the
3932-sync-op-log-multi-operations
branch
from
63d7a63
to
f437d57
Compare
danielkelemen
approved these changes
Mar 6, 2024
Comment on lines
+142
to
+143
| public Map<ProcessInstance, List<PropertyChange>> getPropChangesForOperation(List<ProcessInstance> results) { | ||
| return null; |
There was a problem hiding this comment.
🔧 Depending on how often this will be just return null, this could be a default method in the interface.
| runtimeService.deleteProcessInstance(instance1.getId(), null); | ||
|
|
||
| // then | ||
| UserOperationLogEntry logEntry = historyService.createUserOperationLogQuery().operationType(UserOperationLogEntry.OPERATION_TYPE_DELETE).singleResult(); |
There was a problem hiding this comment.
🔧 Widescreen monitor ftw. You could add some line breaks 😀 (Below too.)
Suggested change
| UserOperationLogEntry logEntry = historyService.createUserOperationLogQuery().operationType(UserOperationLogEntry.OPERATION_TYPE_DELETE).singleResult(); | |
| UserOperationLogEntry logEntry = historyService.createUserOperationLogQuery() | |
| .operationType(UserOperationLogEntry.OPERATION_TYPE_DELETE) | |
| .singleResult(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3932