Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4229 date filter #4305

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

4229 date filter #4305

wants to merge 4 commits into from

Conversation

punitdarira
Copy link
Contributor

Telemetry API now has metrics and date filter.
Made changes in telemetry and metrics api to reuse code.

@punitdarira
feat(engine-rest): Diagnostics API returns metrics filtered by date
4510808 
- telemetry/data now uses the same api of metrics/sum to get metrics with date range

related to camunda#4229
@punitdarira
feat(engine-rest): Diagnostics API returns metrics filtered by date
e7e7558 
- Test changes and documentation.

related to camunda#4229
@punitdarira
feat(engine-rest): Diagnostics API returns metrics filtered by date
e086f9c 
- Added metrics filter

related to camunda#4229
@CLAassistant
Copy link

CLAassistant commented Apr 28, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@danielkelemen danielkelemen self-requested a review May 2, 2024 13:24
@danielkelemen
Copy link
Member

Hi @punitdarira, thank you for your PR!

I'd need a bit more time to review this thoroughly. It already looks pretty good at first sight.
I can already tell you, that we would need a few more tests in the TelemetryRestServiceTest for instance, to test the newly added parameters and the results. But I'll provide more feedback soon.

-Daniel

@punitdarira
Copy link
Contributor Author

Hi @punitdarira, thank you for your PR!

I'd need a bit more time to review this thoroughly. It already looks pretty good at first sight. I can already tell you, that we would need a few more tests in the TelemetryRestServiceTest for instance, to test the newly added parameters and the results. But I'll provide more feedback soon.

-Daniel

Hi @danielkelemen,
I agree regarding the tests. I'll update this PR with the tests.

@tasso94 tasso94 mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkelemen danielkelemen Awaiting requested review from danielkelemen

Assignees

@punitdarira punitdarira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@punitdarira @CLAassistant @danielkelemen