fix(engine-rest): /messages. Return result based on resultType #4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing scenarios performed on this bpmn file |
related to camunda#4310
|
Hi @punitdarira, Thank you for your contribution. We will have a look and get back to you. Stay tuned! Best, |
1 task
yanavasileva
requested changes
May 17, 2024
There was a problem hiding this comment.
👍 I like the made changes in the implementation.
❌ One test case needs to be adjusted to cover MessageCorrelationResultWithVariables use case. In
https://github.com/punitdarira/camunda-bpm-platform/blob/4310-fix/engine-rest/engine-rest/src/test/java/org/camunda/bpm/engine/rest/MessageRestServiceTest.java#L1263
please add a check for the execution like this: checkExecutionResult(content, 0);
There was a problem hiding this comment.
👍 Good catch to adjust this DTO as well and extract the #setExecutionAndProcessInstance() method.
engine-rest/engine-rest/src/test/java/org/camunda/bpm/engine/rest/helper/MockProvider.java
Show resolved
Hide resolved
yanavasileva
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #4310