network: Fix type and respect name when rendering vlan in sysconfig. #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mark this as WIP as I need to check all those failures. |
|
Just for reference, originally inspired from https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/366602 . |
otubo
force-pushed
the
vlan-sysconfig-rendering
branch
from
f1c24d5
to
5487ab6
Compare
OddBloke
requested changes
Sep 7, 2020
OddBloke
reviewed
Sep 15, 2020
Prior to this change, vlans were rendered in sysconfig with 'TYPE=Ethernet', and incorrectly renders the PHYSDEV based on the name of the vlan device rather than the 'link' provided in the network config. The change here fixes: * rendering of TYPE=Ethernet for a vlan * adds a warning if the configured device name is not supported per the RHEL 7 docs "11.5. Naming Scheme for VLAN Interfaces" Forward-ported to cloud-init-20.2: Minimal changes on the order of things on cloudinit/net/sysconfig.py. LP: #1788915 LP: #1826608 rhbz: #1861871 Signed-off-by: Scott Moser <smoser@brickies.net> Signed-off-by: Eduardo Otubo <otubo@redhat.com>
…for vlan naming that's supported.
otubo
force-pushed
the
vlan-sysconfig-rendering
branch
from
fbfde9a
to
7565fc4
Compare
This was referenced May 11, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, vlans were rendered in sysconfig with
'TYPE=Ethernet', and incorrectly renders the PHYSDEV based on
the name of the vlan device rather than the 'link' provided
in the network config.
The change here fixes:
per the RHEL 7 docs "11.5. Naming Scheme for VLAN Interfaces"
Forward-ported to cloud-init-20.2: Minimal changes on the order of
things on cloudinit/net/sysconfig.py.
LP: #1788915
LP: #1826608
rhbz: #1861871
Signed-off-by: Scott Moser smoser@brickies.net
Signed-off-by: Eduardo Otubo otubo@redhat.com