boot.rst: add First Boot Determination section #568
Conversation
There was a problem hiding this comment.
First, thanks for writing this. Second, 2 general comments, with some in-line:
- "first boot", I think really should be consistently "first instance boot" or "first boot of a new instance". cloud-init does identify a "first boot" (per-once) in addition to "first instance boot".
- I'd recommend dropping documentation of internal behavior that we do not necessarily wish to support. Instead, provide a cloud-init sub-command that will do what you want.
2 things you could do:
- cloud-init status could show if manual_cache_clean was set
- some sub-command could toggle the status of manual_cache_clean.
doc/rtd/topics/boot.rst
Outdated
| ID that is present in the system unconditionally. This means that cloud-init | ||
| will never detect a first boot when the cache is present, and it follows that | ||
| the only way to cause cloud-init to detect a first boot is to manually remove | ||
| cloud-init's cache. Internally, this behavior is referred to as ``trust``. |
There was a problem hiding this comment.
I'd just scrap "Internally....".
This is user-facing documentation.
There was a problem hiding this comment.
Scrap the whole sentence, or just "Internally, "?
(If the former: I would like to keep the names of the behaviours, because I think it makes it easier to know where to refer back to when you're reading the later parts of the documentation, and "in trust mode" is more concise than "has manual_cache_clean set to True".)
|
Thanks for the review Scott, this is much improved now. I believe I've addressed all your comments except for the one I've left unresolved. |
There was a problem hiding this comment.
I have no problem with the provided configuration, but just a question regarding instance-id. For EC2, isn't it possible for the instance-id to change without requiring cloud-init to reset the setting of the machine ? For example, if we change the region of an instance I think the instance-id will change, but would we like for cloud-init to reset the setting in that scenario ?
|
I don't think it's possible to move an instance in aws.
https://aws.amazon.com/premiumsupport/knowledge-center/move-ec2-instance/
…On Thu, Sep 10, 2020, 3:31 PM lucasmoura ***@***.***> wrote:
***@***.**** commented on this pull request.
I have no problem with the provided configuration, but just a question
regarding instance-id. For EC2, isn't it possible for the instance-id to
change without requiring cloud-init to reset the setting of the machine ?
For example, if we change the region of an instance I think the
instance-id will change, but would we like for cloud-init to reset the
setting in that scenario ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#568 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAETMLND33GIRF5WNIFOLLSFESQLANCNFSM4Q62PFIA>
.
|
LP: #1888858
LP: #1888858