Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conftest.py: remove top-level import of httpretty #599

Merged
merged 1 commit into from Oct 6, 2020

Conversation

OddBloke
Copy link
Collaborator

@OddBloke OddBloke commented Oct 5, 2020

Proposed Commit Message

conftest.py: remove top-level import of httpretty

This means that the integration tests do not need to install
test-requirements.txt in order to successfully import conftest.py.

Test Steps

tox -e integration-tests still works.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

This means that the integration tests do not need to install
test-requirements.txt in order to successfully import `conftest.py`.
Copy link
Contributor

@paride paride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blackboxsw blackboxsw merged commit 5435205 into canonical:master Oct 6, 2020
This was referenced May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants