Refactor

[rafaelslins]

No description provided.

[codecov-io]

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #38   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      4    +1     
  Lines         552    506   -46     
=====================================
- Hits          552    506   -46

Impacted Files	Coverage Δ
R/functions-new.R	100% <ø> (ø)	⬆️
R/internal.functions-new-code-2.R	100% <100%> (ø)	⬆️
R/plots.R	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a98c4...6884396. Read the comment docs.

[codecov-io]

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #38   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      4    +1     
  Lines         552    506   -46     
=====================================
- Hits          552    506   -46

Impacted Files	Coverage Δ
R/functions-new.R	100% <ø> (ø)	⬆️
R/internal.functions-new-code-2.R	100% <100%> (ø)	⬆️
R/plots.R	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a98c4...6884396. Read the comment docs.

[codecov-io]

Codecov Report

Merging #38 into master will decrease coverage by 19.64%.
The diff coverage is 91.93%.

@@             Coverage Diff             @@
##           master      #38       +/-   ##
===========================================
- Coverage     100%   80.35%   -19.65%     
===========================================
  Files           3        4        +1     
  Lines         552      667      +115     
===========================================
- Hits          552      536       -16     
- Misses          0      131      +131

Impacted Files	Coverage Δ
R/main.functions.R	52.47% <100%> (ø)
R/get.functions.R	100% <100%> (ø)	⬆️
R/plot.functions.R	86.01% <86.01%> (ø)
R/internal.functions.R	98.88% <98.88%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a98c4...8d35d8d. Read the comment docs.

[carloscinelli]

@rafaelslins let us merge only when all changes and new plots are implemented, and everything has been thoroughly tested.

For example, the current version has an error for the error bounds:

data("corporate.payment")
cs <- benford(corporate.payment$Amount)
plot(cs, err.bound = T, select = "digits")

Warning messages:
1: In sqrt(n * ep * (1 - ep)) : NaNs produced
2: In sqrt(n * ep * (1 - ep)) : NaNs produced

[rafaelslins]

Ok, Carlos

[carloscinelli]

@rafaelslins for this bug to not happen again, you can save the bounds of the plot and return invisibly. Then you can write a simple test that checks whether the lower bounds of the plot have the correct values, are not NA etc.