-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace react-bootstrap-table2 with a custom Boostrap table implementation #726
base: master
Are you sure you want to change the base?
Replace react-bootstrap-table2 with a custom Boostrap table implementation #726
Conversation
… of it so the frontend can be started again. These dependencies are not maintained anymore and are incompatible with React 18.
Hi @loic-brtd Also, there are some of the table features that are more nice-to-have, rather than need-to-have. From my point of view, the table only needs to be easy to work with and sortable. Great work! |
… attribute for columns
Hi! Thank you once again for your contribution. Really looking forward to reviewing this. |
Hi 😃 I noticed that the frontend of CastleMock wouldn't build anymore because the following packages haven't been updated for 4 years and are not compatible with React 18 :
As an exercice, I took a bit of time to drop theses dependencies and replace them with a custom DataTable component I built. I made it work with all the existing table configuration code and tried to make it look and behave the same way it did before. So it's almost a one-to-one replacement.
I still have some BootstrapTable components left to replace and test (not the most difficult part). Please let me know if you are interested in merging this pull request once it is complete.