fix: Fix results option #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is based on the available options on jsonResult.php https://github.com/WPO-Foundation/webpagetest/blob/01ea4f9384a1884cfe006dd327039a8bd9eb63c8/www/jsonResult.php#L93 The previous options were based on xmlResult.php file.
|
Sorry we missed this! This is a lot of work! Thanks for doing it @abarre. I think we need to chat as a team about how we want to handle this one. There are a few other potential changes we had in mind that would also be breaking, and it might make sense to wait on this until those are ready too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is based on the available options on jsonResult.php https://github.com/WPO-Foundation/webpagetest/blob/01ea4f9384a1884cfe006dd327039a8bd9eb63c8/www/jsonResult.php#L93
This is a breaking change deprecated options based on xmlResult.php file.