Defined the correct cursorColor for each theme #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
cursorColorisn't explicitly set, XTerm (and other terminals that may use this) uses the incorrect cursor color. This behavior is unlike the other configurations like catppuccin/urxvt or catppuccin/st. I have added the correctcursorColorfor each theme after cross-referencing it from other catppuccin terminal emulator configurations for correctness (for example, Rosewater#dc8a78for Latte, Rosewater#f4dbd6for Macchiato and so on and so forth).Now the correct cursor colors show up. Here's XTerm with Catppuccin Macchiato for example:
Compare with a screenshot from catppuccin/nvim:
