Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small doc fix for cdkAllowingExocyclic() #1060

Merged
merged 1 commit into from Mar 21, 2024

Conversation

JonasSchaub
Copy link
Contributor

cdkAllowingExocyclic() doc says that "exocyclic pi bonds are not allowed to contribute" but they are here, in contrast to cdk(), right?

@johnmay
Copy link
Member

johnmay commented Mar 21, 2024

Yes... BTW all of this is potentially about to be rewritten and optimised. I'm annoyed people still use the CDK aromaticity model as the defacto.

@johnmay johnmay merged commit 904c8f6 into cdk:main Mar 21, 2024
4 of 5 checks passed
@JonasSchaub JonasSchaub deleted the ElectronDonation-small-doc-fix branch March 21, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants