Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RHEL installs honor ceph_origin: distro #559

Merged
merged 1 commit into from Feb 24, 2016

Conversation

stpierre
Copy link
Contributor

Installs on RHEL with ceph_origin set to distro previously would fail
because no packages would get installed, but all of the checks passed
fine. This adds support for ceph_origin: distro, simply installing the
packages using yum/dnf and assuming that the sysadmin has provided a
repository containing them.

This also supports the use case where Satellite or a similar local
mirror is in use, and the admin does not or cannot use the additional
repositories the role would otherwise add.

Installs on RHEL with ceph_origin set to distro previously would fail
because no packages would get installed, but all of the checks passed
fine. This adds support for ceph_origin: distro, simply installing the
packages using yum/dnf and assuming that the sysadmin has provided a
repository containing them.

This also supports the use case where Satellite or a similar local
mirror is in use, and the admin does not or cannot use the additional
repositories the role would otherwise add.
@leseb
Copy link
Member

leseb commented Feb 23, 2016

Why don't you simply set upstream for ceph_distro?
I know it has been a bit of a debate recently.

From my perspective, everything that is not part of the default distro repository is considered as being upstream. As soon as you need to activate an external repo or add an extra repo source this is upstream. Perhaps the term upstream is confusing and we should change it.
If you have any idea.

@stpierre
Copy link
Contributor Author

As far as I can tell, every option for RHEL ends up adding some extra repository, which is explicitly what I need to avoid. If you set ceph_origin: "upstream", then you must also set ceph_stable, ceph_dev, ceph_stable_ice, or ceph_stable_rh_storage, but I don't want to (and cannot) get Ceph from any of those sources because each one of them relies on an external repository. It is possible that "distro" is a little misleading here, but not terribly; it really does just rely on your distro to provide ceph, without any external repo.

@leseb
Copy link
Member

leseb commented Feb 23, 2016

Ok I get your point now, sorry I've read too fast. This is all valid to me.
One thing that bothers me is that I don't think packages named ceph-mon and ceph-osd exist. I think it's RHCS specific so in this case the install might fail.
Not sure of the return code if yum/dnf if the package is not found.

@ktdreyer
Copy link
Member

Packages named "ceph-osd" and "ceph-mon" will exist in Jewel: ceph/ceph#7746

@stpierre
Copy link
Contributor Author

The task errors out if a package cannot be found.

It's also possible that the sysadmin has built hir own RPMs locally, or has mirrored RH Storage with Satellite.

I'll be happy to update the wiki to add more detail about the various installation source options as part of this PR.

@leseb
Copy link
Member

leseb commented Feb 24, 2016

@ktdreyer thanks for the update on that.
@stpierre yes a bit of documentation won't hurt, so please go ahead :).

@stpierre
Copy link
Contributor Author

Wiki updated.

@leseb
Copy link
Member

leseb commented Feb 24, 2016

I can't see you change

@leseb
Copy link
Member

leseb commented Feb 24, 2016

Oh right, thanks for taking the time for this.

leseb added a commit that referenced this pull request Feb 24, 2016
Make RHEL installs honor ceph_origin: distro
@leseb leseb merged commit e9f3e79 into ceph:master Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants