tasks/dump_stuck: fix failure #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
This forces them to be unclean, *then* stale. This ensures that after they are both down they are both *always* unclean, whereas previously it would be possible for them to be only stale and not unclean. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-dump-stuck
branch
from
953ebe0
to
f0dffe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be two problems: one is that the mon's 'pg dump_stuck ...' result
isn't coherent with the health warning. This is fixed by a ceph commit in
ceph/ceph#11339. The other is that this test
didn't account for the fact that when the OSDs went down the PGs would also
appear unclean because they OSDs may not fail simultaneously. That used
to be a hard case to trigger, but with the RST markdown it happens in the
normal case. We adjust this test so that it reliably happens and then
also assert that PGs are unclean.