Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/verify: use rgw_compression_type = "random" #977

Merged
merged 2 commits into from Dec 7, 2016

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Apr 28, 2016

This is my naive attempt to add rgw_compression_type={none, snappy, zlib} to the test matrix of the rgw suite to validate ceph/ceph#7715. I would eventually like to narrow down which parts of the rgw suite test with compression.. maybe just running s3tests against each type is good enough.

This uses the new compressor plugin factory's support for the compression type "random" (see ceph/ceph#11901) to get test coverage of all supported compression types without expanding the test matrix of the rgw suite.

@cbodley cbodley force-pushed the wip-rgw-compression branch 2 times, most recently from cdb41ef to a847b05 Compare May 4, 2016 20:47
@cbodley cbodley changed the title [RFC] rgw: add rgw_compression_type options [DNM] rgw/verify: use rgw_compression_type = "random" Nov 10, 2016
@cbodley cbodley changed the title [DNM] rgw/verify: use rgw_compression_type = "random" rgw/verify: use rgw_compression_type = "random" Nov 21, 2016
@cbodley
Copy link
Contributor Author

cbodley commented Nov 21, 2016

removed [DNM] now that support for rgw_compression_type = "random" merged into master

@cbodley cbodley changed the title rgw/verify: use rgw_compression_type = "random" [DNM] rgw/verify: use rgw_compression_type = "random" Nov 22, 2016
@cbodley
Copy link
Contributor Author

cbodley commented Nov 22, 2016

added [DNM] pending ceph/ceph#12113 which moves the configuration into the zone

@cbodley cbodley force-pushed the wip-rgw-compression branch 3 times, most recently from b4ac3ea to e20c5e3 Compare December 5, 2016 18:45
instead of adding each compression type to the matrix for the rgw/verify
suite, use the new 'random' compression type to get test coverage of
the various compression plugins

this adds an 'rgw compression type' option to the client config, and later
adds that to the zone placement config

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
Copy link
Contributor Author

cbodley commented Dec 7, 2016

updated to use the new zone placement configuration for compression. for multisite tests, it adds this compression field directly into the json format. for non-multisite tests, it runs the new radosgw-admin zone placement modify command to set the compression type

@cbodley cbodley changed the title [DNM] rgw/verify: use rgw_compression_type = "random" rgw/verify: use rgw_compression_type = "random" Dec 7, 2016
@cbodley
Copy link
Contributor Author

cbodley commented Dec 7, 2016

@oritwas
Copy link
Member

oritwas commented Dec 7, 2016

lgtm

@yehudasa yehudasa merged commit 02e7e83 into master Dec 7, 2016
@cbodley cbodley deleted the wip-rgw-compression branch December 7, 2016 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants