os/bluestore: add ExtentMap::add() helper

Matches rm().

Signed-off-by: Sage Weil <sage@redhat.com>

src/os/bluestore/BlueStore.cc

@@ -1933,10 +1933,10 @@ void BlueStore::ExtentMap::punch_hole(
 	uint64_t front = offset - p->logical_offset;
 	old_extents->insert(
 	  *new Extent(offset, p->blob_offset + front, length, p->blob));
-	extent_map.insert(*new Extent(end,
-				      p->blob_offset + front + length,
-				      p->length - front - length,
-				      p->blob));
+	add(end,
+	    p->blob_offset + front + length,
+	    p->length - front - length,
+	    p->blob);
 	p->length = front;
 	break;
       } else {
@@ -1961,8 +1961,7 @@ void BlueStore::ExtentMap::punch_hole(
     uint64_t keep = (p->logical_offset + p->length) - end;
     old_extents->insert(*new Extent(p->logical_offset, p->blob_offset,
 				    p->length - keep, p->blob));
-    extent_map.insert(*new Extent(end, p->blob_offset + p->length - keep, keep,
-				  p->blob));
+    add(end, p->blob_offset + p->length - keep, keep, p->blob);
     rm(p);
     break;
   }
@@ -7979,9 +7978,7 @@ int BlueStore::_clone(TransContext *txc,
 	}
       }
       // dup extent
-      newo->extent_map.extent_map.insert(*new Extent(e.logical_offset,
-						     e.blob_offset,
-						     e.length, cb));
+      newo->extent_map.add(e.logical_offset, e.blob_offset, e.length, cb);
       txc->statfs_delta.stored() += e.length;
       if (e.blob->get_blob().is_compressed()) {
 	txc->statfs_delta.compressed_original() -= e.length;

src/os/bluestore/BlueStore.h

@@ -605,6 +605,11 @@ class BlueStore : public ObjectStore,
     /// seek to the first lextent including or after offset
     extent_map_t::iterator seek_lextent(uint64_t offset);
 
+    /// add a new Extent
+    void add(uint32_t lo, uint32_t o, uint32_t l, BlobRef& b) {
+      extent_map.insert(*new Extent(lo, o, l, b));
+    }
+
     /// remove (and delete) an Extent
     void rm(extent_map_t::iterator p) {
       Extent *e = &*p;