Skip to content

Commit

Permalink
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
Browse files Browse the repository at this point in the history
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
  • Loading branch information
Loic Dachary committed Aug 9, 2016
2 parents e0b06bc + 47605a2 commit 47d2e93
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 6 deletions.
20 changes: 19 additions & 1 deletion src/msg/msg_types.h
Expand Up @@ -251,7 +251,21 @@ struct entity_addr_t {
return addr6;
}

bool set_sockaddr(struct sockaddr *sa)
const sockaddr *get_sockaddr() const {
return (const sockaddr *)&addr4;
}
size_t get_sockaddr_len() const {
switch (addr.ss_family) {
case AF_INET:
return sizeof(addr4);
break;
case AF_INET6:
return sizeof(addr6);
break;
}
return sizeof(addr);
}
bool set_sockaddr(const struct sockaddr *sa)
{
switch (sa->sa_family) {
case AF_INET:
Expand All @@ -266,6 +280,10 @@ struct entity_addr_t {
return true;
}

sockaddr_storage get_sockaddr_storage() const {
return addr;
}

void set_in4_quad(int pos, int val) {
addr4.sin_family = AF_INET;
unsigned char *ipq = (unsigned char*)&addr4.sin_addr.s_addr;
Expand Down
10 changes: 5 additions & 5 deletions src/osd/OSD.cc
Expand Up @@ -4057,14 +4057,14 @@ void OSD::heartbeat_check()
if (p->second.is_unhealthy(cutoff)) {
if (p->second.last_rx_back == utime_t() ||
p->second.last_rx_front == utime_t()) {
derr << "heartbeat_check: no reply from osd." << p->first
<< " ever on either front or back, first ping sent " << p->second.first_tx
<< " (cutoff " << cutoff << ")" << dendl;
derr << "heartbeat_check: no reply from " << p->second.con_front->get_peer_addr().get_sockaddr()
<< " osd." << p->first << " ever on either front or back, first ping sent "
<< p->second.first_tx << " (cutoff " << cutoff << ")" << dendl;
// fail
failure_queue[p->first] = p->second.last_tx;
} else {
derr << "heartbeat_check: no reply from osd." << p->first
<< " since back " << p->second.last_rx_back
derr << "heartbeat_check: no reply from " << p->second.con_front->get_peer_addr().get_sockaddr()
<< " osd." << p->first << " since back " << p->second.last_rx_back
<< " front " << p->second.last_rx_front
<< " (cutoff " << cutoff << ")" << dendl;
// fail
Expand Down

0 comments on commit 47d2e93

Please sign in to comment.