Merge pull request #12580 from Liuchang0812/fix-clang-warn-client

client: fix clang warn of "argument is an uninitialized value" Reviewed-by: Sage Weil <sage@redhat.com>
ceph · Jan 9, 2017 · 96375cd · 96375cd
2 parents 572a09c + 883d9b1
commit 96375cd
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/client/Client.cc b/src/client/Client.cc
@@ -7143,7 +7143,9 @@ int Client::opendir(const char *relpath, dir_result_t **dirpp, const UserPerm& p
       return r;
   }
   r = _opendir(in.get(), dirpp, perms);
-  tout(cct) << (unsigned long)*dirpp << std::endl;
+  /* if ENOTDIR, dirpp will be an uninitialized point and it's very dangerous to access its value */
+  if (r != -ENOTDIR)
+      tout(cct) << (unsigned long)*dirpp << std::endl;
   return r;
 }