jewel: rgw: master: build failures with boost > 1.58 #10026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boost > 1.58 no longer includes in_place in boost/utility, we need to include in_place_factory explicitly. This causes build failures in distros that ship with a higher version of boost. Since the only call is for swift_ver_location, another possibility is to use emplace() instead (though this requires boost ~ 1.56) Fixes: http://tracker.ceph.com/issues/16391 Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com> (cherry picked from commit a14f0f3) Conflicts: src/rgw/rgw_rest_swift.cc jewel does not have #include <boost/optional.hpp>
ghost
pushed a commit
that referenced
this pull request
Jun 30, 2016
… 1.58 Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 1, 2016
… 1.58 Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@oritwas does this backport look good to merge ? It passed the rgw suite http://tracker.ceph.com/issues/16344#note-12, except for one transient error which seems unrelated to this backport. |
ghost
pushed a commit
that referenced
this pull request
Aug 8, 2016
… 1.58 Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 9, 2016
… 1.58 Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16392