cmake: Removed README.cmake.md, edited README.md #10028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivancich would be great if you could take a quick look at this. |
| -DCMAKE_INSTALL_PREFIX=/opt/accelio -DCMAKE_C_FLAGS="-O0 -g3 -gdwarf-4" \ | ||
| [path to top level ceph directory] | ||
|
|
||
| If you often pipe `make`to `less` and would like to maintain the |
|
|
| @@ -114,12 +151,17 @@ To start or stop individual daemons, the sysvinit script can be used: | |||
| Running unit tests | |||
| ================== | |||
|
|
|||
| To run build and run all tests, use ctest: | |||
| To run build and run all tests run in `make check`, use ctest: | |||
There was a problem hiding this comment.
I'm guessing "run build" means simply "build" unless build is a command. Would this be better?
To build and run all tests that are executed during `make check`, use `ctest`:
alimaredia
force-pushed
the
wip-cmake-readme-fixes
branch
from
e38b056
to
30e2622
Compare
|
|
||
| cd build | ||
| make check -j$(nproc) | ||
|
|
||
| To run an individual test manually, run the ctest command with -R | ||
| (regex matching): | ||
|
|
||
| ctest -R [test name] |
There was a problem hiding this comment.
If -R indicates regex matching, then the argument is not "test name" but rather "regex matching test name(s)".
Deleted README.cmake.md and put any helpful information it had into README.md. Also a added note about which tests get executed by ctest. Signed-off-by: Ali Maredia <amaredia@redhat.com>
alimaredia
force-pushed
the
wip-cmake-readme-fixes
branch
from
30e2622
to
af6e986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted README.cmake.md and put any helpful
information it had into README.md.
Also a added note about which tests get executed
by ctest.
Signed-off-by: Ali Maredia amaredia@redhat.com