os/bluestore: make zone/span size of bitmap-allocator configurable #10040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chhabaramesh I move the size-change commit into this pr(a much clean place). Please look at here, thanks! |
xiexingguo
force-pushed
the
xxg-wip-bit-alloc-tree-configurable
branch
from
773869c
to
8b73dc6
Compare
|
@chhabaramesh Thoughts? |
|
@xiexingguo , I will review it on weekend, sorry for delay, got stuck in some other tasks. |
|
@chhabaramesh Okay, just a reminder that I move the change here, take your time. |
|
@chhabaramesh Ping |
|
@chhabaramesh Are you there...? |
|
He's on vacation.. back next week. |
| @@ -26,7 +27,7 @@ | |||
|
|
|||
| int64_t BitMapAreaLeaf::count = 0; | |||
| int64_t BitMapZone::count = 0; | |||
| int64_t BitMapZone::total_blocks = BITMAP_SPAN_SIZE; | |||
|
@xiexingguo @liewegas Overall changes looks ok to me. |
Perviously as zone_size_block and span_size are identical, so we could use span_size only to simplify the calcuation. Now that the zone_size_block and span_size are both configurable, so it is necessary to treat them respectively. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
For testing, we may choose randomized length of extent to allocate, which means we could trim down the length to 0. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bit-alloc-tree-configurable
branch
from
3ba1ca9
to
af82dbc
Compare
|
@chhabaramesh Thanks for the review, all fixed and passed the test again. @liewegas This one is safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perviously as zone_size_block and span_size are identical, so we could use
span_size only to simplify the calculation.
Now that the zone_size_block and span_size are both configurable, so
it is necessary to treat them respectively.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn