cmake changes #10059
Merged
cmake changes #10059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -0,0 +1,16 @@ | |||
| install(FILES | |||
There was a problem hiding this comment.
rpm packaging relies on the building system to put these files in place.
qa task rados/objectstore/keyvaluedb.yaml uses it. Signed-off-by: Kefu Chai <kchai@redhat.com>
add an option "WITH_SYSTEMD", off by default Signed-off-by: Kefu Chai <kchai@redhat.com>
this address rpm build failures on amd64 platforms: Directory not found: /srv/autobuild-ceph/gitbuilder.git/build/rpmbuild/BUILDROOT/ceph-11.0.0-119.gcd3ee3c.x86_64/usr/lib64/rados-classes File not found by glob: /srv/autobuild-ceph/gitbuilder.git/build/rpmbuild/BUILDROOT/ceph-11.0.0-119.gcd3ee3c.x86_64/usr/lib64/rados-classes/* File not found by glob: /srv/autobuild-ceph/gitbuilder.git/build/rpmbuild/BUILDROOT/ceph-11.0.0-119.gcd3ee3c.x86_64/usr/lib64/libos_tp.so* File not found by glob: /srv/autobuild-ceph/gitbuilder.git/build/rpmbuild/BUILDROOT/ceph-11.0.0-119.gcd3ee3c.x86_64/usr/lib64/libosd_tp.so* Signed-off-by: Kefu Chai <kchai@redhat.com>
was using selinux/devel/include/Makefile, which was wrong. Signed-off-by: Kefu Chai <kchai@redhat.com>
| @@ -63,6 +63,7 @@ if(WITH_RBD) | |||
| rbd-nbd.rst | |||
| rbd-replay-prep.rst | |||
| rbd-replay.rst | |||
| rbd-replay.rst | |||
There was a problem hiding this comment.
fixed and repushed
rpm packaging needs it explicitly. Signed-off-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the issues found in http://pulpito.ceph.com/kchai-2016-06-29_23:29:27-rados-master---basic-smithi/ and http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-rpm-centos7-amd64-basic/log.cgi?log=f00b9c8d00bd15e732d79eda13b533eaebf20636