os/bluestore: improve required compression threshold #10080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| uint64_t dstlen = final_length * | ||
| g_conf->bluestore_compression_required_ratio; | ||
| dstlen = ROUND_UP_TO(dstlen, min_alloc_size); | ||
| if (newlen < dstlen) { |
There was a problem hiding this comment.
i would do <=, as .125 is 1/8 and it is likely we'll actually hit that pretty frequently. maybe also keep newlen < final_length in there too, as the configured min after rounding up might == final_length?
|
At some point we probably also want a heuristic that makes us stop trying to compress writes to an object if they never compress down.. |
…ssion Require the net gain of compression at least to be at a specified ratio, otherwise we don't compress. Ask for compressing at least 12.5% off, by default. This is for the sake of performance because if the compression turns out to be meaningless(saving little space), we can simply shut it down, as we know the compression/decompression can be rather CPU-consuming. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-add-compress-ratio
branch
from
819e854
to
0f70647
Compare
|
@liewegas Done.
Well, I'll try... |
|
we don't have to do it now, but we should think about how it might be
done. it'll be tricky!
|
|
Okay, do you still want this change? |
liewegas
changed the title
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssion
Require the net gain of compression at least to be at a specified ratio,
otherwise we don't compress.
Ask for compressing at least 12.5% off, by default.
This is for the sake of performance because if the compression turns out
to be meaningless(saving little space), we can simply shut it down, as we
know the compression/decompression can be rather CPU-consuming.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn