cmake: remove unnecessary linked libs from libcephfs #10081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* some of the libs shares the same .cc which has static C++ variables. if we link against the different libs sharing the same static C++ variables, and the dtor of the C++ variables has side-effects, among other things, deallocates a memory chunk. then, we are in the trouble of double free. so "osd" lib is removed. * some of the libs are referenced by the linked lib, so no need to link against them again. for example, BLKID_LIBRARIES are linked by libcommon, so we can remove it from the linked libs list. * and lib "os" and "cls_references_objs" are not used by libcephfs at all, so remove them. Fixes: http://tracker.ceph.com/issues/16556 Signed-off-by: Kefu Chai <kchai@redhat.com>
|
Tested this locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we link against the different libs sharing the same static C++
variables, and the dtor of the C++ variables has side-effects, among
other things, deallocates a memory chunk. then, we are in the trouble of
double free.
against them again. for example, BLKID_LIBRARIES are linked by
libcommon, so we can remove it from the linked libs list.
Fixes: http://tracker.ceph.com/issues/16556
Signed-off-by: Kefu Chai kchai@redhat.com