rgw: conform to the standard usage of string::find #10086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int eqpos = param.find('='); | ||
| if (eqpos > 0) { | ||
| size_t eqpos = param.find('='); | ||
| if (eqpos != string::npos) { | ||
| string param_name = rgw_trim_whitespace(param.substr(0, eqpos)); | ||
| string val = rgw_trim_quotes(param.substr(eqpos + 1)); |
There was a problem hiding this comment.
don't need val; avoid a possible copy
|
@Yan-waller one nit found (ideas on improving the clarity of this sort of code would be welcome:) |
Yan-waller
force-pushed
the
yj-wip-rgwrests3ccstringfind
branch
2 times, most recently
from
9d4496e
to
fa635c4
Compare
Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
|
@mattbenjamin thanks, I have fixed it and kill some compiling warnings. |
|
retest this please |
|
lgtm |
mattbenjamin
approved these changes
Nov 29, 2016
| string param_name = rgw_trim_whitespace(param.substr(0, eqpos)); | ||
| string val = rgw_trim_quotes(param.substr(eqpos + 1)); | ||
| params[param_name] = val; | ||
| size_t eqpos = param.find('='); |
There was a problem hiding this comment.
can see why the original made steps explicit; this is smaller but has the same effect, iiuc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yan Jun yan.jun8@zte.com.cn