Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix usage info of omapbench #10089

Merged
merged 1 commit into from Jul 25, 2016
Merged

Conversation

gaowanlong
Copy link
Contributor

Fix the default value info of "--omaptype" and the wrong indent
of "--name" option.

Signed-off-by: Wanlong Gao wanlong.gao@easystack.cn

cout <<"\n --name the rados id to use (default "<<rados_id;
cout<<")\n";
<< " (default uniform)\n";
cout << " --name the rados id to use (default "<<rados_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the ident of --name should be a single space? and might want to add a space before rados_id.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaikov Nope, it's a tab, if you can do "set list" in vim, you can see that other lines are all tabs, that why the "--name" option is not aligned with others.
While the space before rados_id, anyway, I didn't add the space just want to keep consistent with others above it, like "threads", "objests", etc.

Copy link
Contributor

@tchaikov tchaikov Jul 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add the space just want to keep consistent with others above it, like "threads", "objests", etc.

please take this chance to add the space since you are changing this line anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take this chance to add the space since you are changing this line anyway.

@tchaikov OK, updated now. ;)

Fix the default value info of "--omaptype" and the wrong indent
of "--name" option.

Signed-off-by: Wanlong Gao <wanlong.gao@easystack.cn>
@tchaikov
Copy link
Contributor

lgtm

@tchaikov tchaikov merged commit b96cfc3 into ceph:master Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants