systemd: add osd id to service description #10091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, instead of logging this: Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon. Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon. Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon. Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon. Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon. Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon. Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon. Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon. Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon. Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon. We see this, which is a lot more useful: Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.27. Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.32. Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.29. Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.31. Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.23. Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.24. Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.25. Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.30. Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.28. Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.22.
|
lgtm. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, instead of logging this:
Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon.
Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon.
Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon.
Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon.
Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon.
Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon.
Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon.
Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon.
Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon.
Jul 01 13:51:04 localhost systemd[1]: Failed to start Ceph object storage daemon.
We see this, which is a lot more useful:
Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.27.
Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.32.
Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.29.
Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.31.
Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.23.
Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.24.
Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.25.
Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.30.
Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.28.
Jul 01 13:59:32 localhost systemd[1]: Failed to start Ceph object storage daemon osd.22.