crush: reset bucket->h.items[i] when removing tree item #10093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* crush: so we don't see the reference after the removing, this keeps check_item_loc() happy, and move_bucket() use check_item_loc() to see if the removed bucket disappears after the removal. * test: also add unittest_crush_wrapper::CrushWrapper.insert_item Fixes: http://tracker.ceph.com/issues/16525 Signed-off-by: Kefu Chai <kchai@redhat.com>
|
@liewegas mind taking a look? |
|
looks good to me! |
|
@tchaikov , sorry, I tried to reproduce in my env with hammer and jewel but didn't see this bug...but it's really a bug from code...would you mind sharing how this can be trigger? I did everything looks fine |
|
@xiaoxichen you could try to reproduce it using the crush map offered by http://tracker.ceph.com/issues/16525. to trigger this issue, in short
|
|
@tchaikov , thanks ,good to know, we are safe as we are in straw:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_item_loc() happy, and move_bucket() use check_item_loc() to see if
the removed bucket disappears after the removal.
Fixes: http://tracker.ceph.com/issues/16525
Signed-off-by: Kefu Chai kchai@redhat.com