New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jewel: fs: client: FAILED assert(root_ancestor->qtree == __null) #10107
Conversation
Multiple clients can modify cephfs at the same time. It is very tricky to keep QuotaTree consistant with the global FS hiberarchy. This patch kills the quota tree. After removing the quota tree, we traverse inode's path to find quota root. Fixes: http://tracker.ceph.com/issues/16066 Fixes: http://tracker.ceph.com/issues/16067 Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit 161954b)
2051d0f
to
54b6b5e
Compare
@xiaoxichen I'm setting milestone jewel since this is targeting jewel really. If that's a mistake please let me know. |
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
@jcsp does this backport look good to merge ? It passed the fs suite http://tracker.ceph.com/issues/16344#note-21 (except for unrelated valgrind failures and one transient failure that is, I believe, unrelated ). |
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ukernel, can you sign-off on this since John's on vacation another week? |
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
LGTM, this is a clean cherry-pick right? |
@jcsp yes. Please do not merge anything until 10.2.3 is released. And welcome back :-) |
Signed-off-by |
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
…->qtree == __null) Reviewed-by: Loic Dachary <ldachary@redhat.com>
http://tracker.ceph.com/issues/16313