Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: fix incorrect pool decoding of bnode #10117

Merged
merged 1 commit into from Jul 4, 2016

Conversation

xiexingguo
Copy link
Member

"pool" is a pointer, and we shall alter its value instead.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

"pool" is a pointer, and we shall alter its value instead.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@liewegas
Copy link
Member

liewegas commented Jul 4, 2016

The first patch is right, thanks! The second one is unnecessary.. the ref_map is used for a single blob, which will never exceed a few megabytes (let alone 4gb). And the block_mask may be used in the future (and could probably used effectively in several places now). Can you drop teh last two? Thanks!

@xiexingguo xiexingguo force-pushed the xxg-wip-bluestore-2016-07-04 branch from c24521b to 29d2931 Compare July 4, 2016 13:31
@xiexingguo
Copy link
Member Author

Done.

@liewegas liewegas merged commit fa8107a into ceph:master Jul 4, 2016
@xiexingguo xiexingguo deleted the xxg-wip-bluestore-2016-07-04 branch July 4, 2016 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants