Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: for the create_bucket api, if the input creation_time is zero, we should set it to 'now" #10118

Merged
merged 1 commit into from Aug 15, 2016

Conversation

weiqiaomiao
Copy link
Contributor

@weiqiaomiao weiqiaomiao commented Jul 4, 2016

For the create_bucket api, if the input creation_time is zero, we should set it to 'now"

Fixes: http://tracker.ceph.com/issues/16597

Signed-off-by: weiqiaomiao wei.qiaomiao@zte.com.cn

@xiexingguo xiexingguo added the rgw label Jul 4, 2016
@oritwas
Copy link
Member

oritwas commented Jul 5, 2016

looks good.
can you open a tracker issue and add it to the commit message (using Fixes label)

@oritwas oritwas added the bug-fix label Jul 5, 2016
@weiqiaomiao
Copy link
Contributor Author

@oritwas ok, already updated it. would you take a look at it again.

@oritwas
Copy link
Member

oritwas commented Jul 11, 2016

@weiqiaomiao , please add it to the commit message

@weiqiaomiao
Copy link
Contributor Author

@oritwas , I already added the tracker issue as bellow to the commit message:
Fixes: http://tracker.ceph.com/issues/16597
Is there any info need to included in ?

@oritwas
Copy link
Member

oritwas commented Jul 11, 2016

@weiqiaomiao , looking at the commit I don't see the info ed781e7
you need to add it to the commit comment (you need to do is git commit --amend, edit the comment and than git push -f)

@weiqiaomiao
Copy link
Contributor Author

@oritwas Oh~i get it, many thanks for you. done

@weiqiaomiao
Copy link
Contributor Author

retest this please

…e should set it to 'now"

Fixes: http://tracker.ceph.com/issues/16597

Signed-off-by: weiqiaomiao <wei.qiaomiao@zte.com.cn>
@oritwas oritwas merged commit 16c1a7d into ceph:master Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants